Re: [Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

I don't feel knowledgeable enough to backport the commit, so if you can do it, it would be great :) Il giorno gio 4 feb 2021 alle ore 13:04 Martin Storsjö via Phabricator < revi...@reviews.llvm.org> ha scritto: > mstorsjo added a comment. > > In D96060#2542890

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

mstorsjo added a comment. In D96060#2542890 , @mstorsjo wrote: > I can test build it in a couple hours It still built fine for me now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96060/new/ http

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

mstorsjo added a comment. The change looks ok to me. In my environments, the main branch does build correctly, but this should be good for consistency in any case. (The 12.x release branch does need a cherrypick though - but it'd be good to settle this first.) I can test build it in a couple h

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36496cc2992d: [lldb-vscode] correctly use Windows macros (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM, I had to do this to fix it locally and can confirm it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

wallace created this revision. wallace added reviewers: mstorsjo, stella.stamenova. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @mstorsjo found a mistake that I made when trying to fix some Windows compilation errors encountered