[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, mib wrote: > stella.st

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, stella.stamenova wrote: > This

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, This is where the

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 333114. mib marked an inline comment as done. mib added a comment. Addressing @stella.stamenova feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/incl

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:114 + create_python_package( +${swig_target} stella.stamenova wrote: > How is this different than the package on line 107? This might have been copied twice ... getting rid of it.

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should f

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:114 + create_python_package( +${swig_target} How is this different than the package on line 107? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added a comment. With the help of @teemperor, I was able to test that my latest changes work on Linux with and without enabling python for lldb. I'll re-land the patch and monitor the bots to make sure there is no other issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 333054. mib marked 2 inline comments as done. mib added a reviewer: teemperor. mib added a comment. Enable `ScriptedProcess` process plugin only when `LLDB_ENABLE_PYTHON` is true. This should fix the test failures that happen when python support is disabled. Re

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

teemperor added a comment. In D95713#2647722 , @davezarzycki wrote: > In D95713#2647548 , @teemperor wrote: > >> The tests are failing because Dave's bot is running without enabled Python. >> The same is true for

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should fix t

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

teemperor added a comment. The tests are failing because Dave's bot is running without enabled Python. The same is true for the Windows bot. Putting the plugin behind `#ifdef LLDB_ENABLE_PYTHON` should fix this. FWIW, even with enabled Python this seems to have some minor problems with command

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added a comment. In D95713#2647241 , @davezarzycki wrote: > I've reverted this. If you need help debugging this, please let me know. > Also, as a reminder, please see the attached build log from earlier in the > conversation. Thanks! @davezarzycki

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. I've reverted this. If you need help debugging this, please let me know. Also, as a reminder, please see the attached build log from earlier in the conversation. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. An auto-bisecting cron job has identified this change as a regression on Fedora 33 (x86-64). Can we get a quick fix or revert this? Here is the build output: https://znu.io/dd391e1ef762d79f86112dc2480a89c9be066ce1-bisect.txt Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46796762afe7: [lldb/Plugins] Add ScriptedProcess Process Plugin (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 327216. mib added a comment. Add support for loading a corefile. Fix incomplete scripted process instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lld

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324813. mib added a comment. Test `ScriptedProcess::ReadMemory` Test launching the scripted process from both the command line and from the `SBAPI`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324587. mib added a comment. Fix test typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/bindings/python/CMakeLists.txt lldb/include/lldb/Target/Process.

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324564. mib marked 4 inline comments as done. mib added a comment. Address @JDevlieghere feedbacks: - Make test more portable - Add helper function to get the `ScriptedProcessInterface` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py:55 +scripted_process_example_relpath = "../../../../examples/python/scripted_process/my_scripted_process.py" +os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH']

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:117 + if (m_interpreter) +m_pid = m_interpreter->GetScriptedProcessInterface().GetProcessID(); +} `m_interpreter->GetScriptedProcessInterface()` seems to

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324075. mib added a comment. Update `ScriptedProcess::GetMemoryRegions` to load regions lazily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 323945. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source/Plugins/Process/scripted/CMakeLists.txt lldb/sourc

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 323943. mib marked 10 inline comments as done. mib added a comment. - Address @JDevlieghere comments: - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: ll

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/CMakeLists.txt:16 endif() +add_subdirectory(Scripted) add_subdirectory(gdb-remote) nit: I'd make this lowercase for consistency with the other plugins (and keep Utility the exception a

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 320287. mib edited the summary of this revision. mib added a comment. - Set Process PID in `ScriptedProcess::DidLaunch` - Updated `ScriptedProcess::DoReadMemory` implementation. - Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 320249. mib added a comment. Fix typo in copyright header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 320248. mib added a comment. Remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source/Plugins/Pro

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib created this revision. mib added reviewers: jasonmolenda, jingham, JDevlieghere, labath, LLDB. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces Scripted Processes to lldb. The go