[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

teemperor added a comment. From what I understand this means D91378 is no longer necessary. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94917/new/ https://reviews.llvm.org/D94917 ___

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a7672ac4980: [lldb] Fix crash in "help memory read" (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D94917?vs=3173

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/OptionDefinition.h:52 +// Must not have any bits set outside of unsigned char range +return !(short_option & ~((1 << CHAR_BI

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. UBSAN might have caught this if we had a test that took this path but I need to confirm that. If so I could add some more as a smoke test of sorts, or just call help on every command if that's not going to take an age. See

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a command option does not have a short version (e.g. -f for --file), we use an arbitrary value in the short_option field to mark it as i