[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

2020-10-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5b17b6d924d2: [lldb] Ignore binary data in crashlog (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.llv

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

2020-10-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D90414#2364816 , @aprantl wrote: > Just FYI, we do have unit tests for the crashlog parser now, but I don't know > how well this fits in there. I see a test that generates one and that checks some regexes, but no test tha

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

2020-10-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Just FYI, we do have unit tests for the crashlog parser now, but I don't know how well this fits in there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

2020-10-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 301716. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.llvm.org/D90414 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

2020-10-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 301714. JDevlieghere added a comment. Fix indentation that got screwed up when staging only non-whitespace changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.llvm.org/D90414 Files: lldb/examples/python/crashlog

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

2020-10-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda. Herald added a project: LLDB. JDevlieghere requested review of this revision. Skip the instruction stream section in the crashlog section. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D904