This revision was automatically updated to reflect the committed changes.
Closed by commit rG206e8d890503: Fix SBError::SetErrorToGenericError (authored
by werat, committed by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90151/new/
http
werat added a comment.
Thanks! Yeah, I don't have commit access, thanks for landing it for me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90151/new/
https://reviews.llvm.org/D90151
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Thanks! I assume you don't have commit access, so I'll land this for you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90151/new/
https://reviews.llvm.org/D90151
_
werat updated this revision to Diff 300652.
werat added a comment.
Add a test case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90151/new/
https://reviews.llvm.org/D90151
Files:
lldb/source/API/SBError.cpp
lldb/test/API/python_api/sberror/TestSBError.py
Index: lldb/test/API/pyt
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Could you add a test for this? This should be enough:
diff --git a/lldb/test/API/python_api/sberror/TestSBError.py
b/lldb/test/API/python_api/sberror/TestSBError.py
new fil
werat created this revision.
werat added a reviewer: JDevlieghere.
werat added a project: LLDB.
Herald added a subscriber: lldb-commits.
werat requested review of this revision.
`SBError::SetErrorToGenericError` should call `Status::SetErrorToGenericError`,
not `Status::SetErrorToErrno`.
Reposi
