[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG73811d32c72d: [lldb] Move copying of files into reproducer out of process (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Reproducer.cpp:389 + + if (auto files = llvm::MemoryBuffer::getFile(files_path)) { +SmallVector paths; labath wrote: > Is this deliberately ign

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lldb/source/Utility/Reproducer.cpp:371 + + SmallVector paths; + (*buffer)->getBuffer().split(paths, '\0'); I'd expect this to conta

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere updated this revision to Diff 300051. JDevlieghere marked 6 inline comments as done. JDevlieghere added a comment. Address Pavel's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89600/new/ https://reviews.llvm.org/D89600 Files: lldb/include/lldb/API/S

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

labath added a comment. In D89600#2338996 , @JDevlieghere wrote: > In D89600#2337868 , @labath wrote: > >> Hm... Are you sure that this will help with anything? IIUC, the >> serialization of the VFS file map still

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere updated this revision to Diff 299214. JDevlieghere added a comment. - Implement a FlushingFileCollector that appends paths to a file - Create the mapping out-of-process - Add an InProcessFinalizer that uses the current reproducer instance to copy over the files in-process CHANGES S

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere planned changes to this revision. JDevlieghere added a comment. In D89600#2337868 , @labath wrote: > Hm... Are you sure that this will help with anything? IIUC, the serialization > of the VFS file map still happens in the context of the crash

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

labath added a comment. Hm... Are you sure that this will help with anything? IIUC, the serialization of the VFS file map still happens in the context of the crashing process. This requires walking a bunch of data structures with liberally-asserting code, which will abort on any inconsistency i

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, vsk, jingham. Herald added a subscriber: dang. JDevlieghere requested review of this revision. For performance reasons the reproducers don't copy the files captured by the file collector until we decide that the