[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5fa63fd140: [lldb] Port lldb gdb-server to libOption (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Utility/Args.cpp:178 +Args::Args(llvm::ArrayRef args) : Args() { + for (llvm::StringRef arg : args) labath wrote:

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:405 + bool HasError = false; + opt::InputArgList Args = Opts.parseArgs(argc - 1, argv + 1, OPT_UNKNOWN, + Saver, [&](llvm::StringRef Msg) { -

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:405 + bool HasError = false; + opt::InputArgList Args = Opts.parseArgs(argc - 1, argv + 1, OPT_UNKNOWN, + Saver, [&](llvm::StringRef Msg) {

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath updated this revision to Diff 298606. labath marked an inline comment as done. labath added a comment. address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89477/new/ https://reviews.llvm.org/D89477 Files: lldb/include/ll

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Utility/Args.cpp:178 +Args::Args(llvm::ArrayRef args) : Args() { + for (llvm::StringRef arg : args) JDevlieghere wrote: > Maybe StringList should have a ctor that ta

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

DavidSpickett added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:370 + If no target is selected a startup, the lldb-server can be directed to launch + or attach a process by the LLDB client. + `attach a process` -> `attach to a process

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:369 + + If no target is selected a startup, the lldb-server can be directed to launch + or attach a process by the LLDB client. `a startup` -> `at startup` Repository: rG L

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:404 + unsigned MissingArgCount; + opt::InputArgList Args = Opts.ParseArgs(makeArrayRef(argv + 2, argc - 2), + MissingArgIndex, MissingArgCount); ---

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/CMakeLists.txt:61 LINK_COMPONENTS Support ) Otherwise it fails in a BUILD_SHARED_LIBS=on build because the -Wl,-z,defs linker option requires a module to have fully specified dependen

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Args.cpp:178 +Args::Args(llvm::ArrayRef args) : Args() { + for (llvm::StringRef arg : args) Maybe StringList should have a ctor that takes an `ArrayRef`, but probably not worth the extra copi

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath created this revision. labath added reviewers: JDevlieghere, MaskRay. Herald added subscribers: dang, mgorny. Herald added a project: LLDB. labath requested review of this revision. The existing help text was very terse and was missing several important options. In the new version, I add a