[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Target/TraceProcess.cpp:40 +bool TraceProcess::CanDebug(TargetSP target_sp, bool plugin_specified_by_name) { return plugin_specified_by_name; } labath wrote: > M

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace updated this revision to Diff 298671. wallace marked an inline comment as done. wallace added a comment. Herald added a subscriber: dexonsmith. Address all comments, including the renaming of the classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

labath added a comment. In D89408#2333502 , @wallace wrote: > Addressed the issues that @labath pointed out regarding the TraceProcess and > TraceThread: > > - These classes were not together > - TraceProcess was an optional plug-in, which would break the

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace updated this revision to Diff 298493. wallace added a comment. Herald added a reviewer: JDevlieghere. Addressed the issues that @labath pointed out regarding the TraceProcess and TraceThread: - These classes were not together - TraceProcess was an optional plug-in, which would break the

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

labath added a comment. Making this a separate patch is a good idea, but it does not materially address my objections to having ProcessTrace and ThreadTrace live in two different places. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace updated this revision to Diff 298211. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/ https://reviews.llvm.org/D89408 Files: lldb/include/lldb/Target/TraceSessionFileParser.h lldb/include/lldb/Tar