[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08924b54debc: [lldb] Remove unused code in GetVersion (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yeah there isn't a lot of unused code left here. If you want you can make a follow up replacing all the C-string logic with `std::string` (and removing the static local result var as tha

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296700. kastiglione added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.c

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added a comment. @teemperor I removed the comment and restored repository handling. It becomes much more of a useless diff :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 ___

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296695. kastiglione added a comment. Restore repository handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

teemperor added a reviewer: JDevlieghere. teemperor added a comment. LLDB_REVISION and LLDB_REPOSITORY are coming from VCSVersion.inc where it should be defined as a string. However the generation of that file seems to be broken since the monorepo migration. I put up a patch here that gets this

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added inline comments. Comment at: lldb/source/lldb.cpp:22 #ifdef LLDB_REVISION return LLDB_REVISION; #else this won't expand to a string as is, does this indicate it's unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296579. kastiglione added a comment. switch NULL to "" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp =

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296578. kastiglione added a comment. Unbreak code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp ==

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Small cleanup to `lldb_private::GetVersion()`. In parti