[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

2020-08-27 Thread David Spickett via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e6f1a7b1a8: [lldb] Fix gcc 5.4.0 compile error (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

2020-08-27 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86690/new/ https://reviews.llvm.org/D86690 __

[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

2020-08-27 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a reviewer: labath. DavidSpickett added a comment. https://www.llvm.org/docs/GettingStarted.html gives the minimum gcc as 5.1. (I found this cross compiling, the apt package for AArch64 is 5.4.0) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

2020-08-27 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. Specify type when constructing PromotionKeys, this fixes error: "chosen constructor is explicit in c