[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e6c9a6e7940: Add hashing of the .text section to ProcessMinidump. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

labath accepted this revision. labath added a comment. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86261/new/ https://reviews.llvm.org/D86261 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg updated this revision to Diff 287078. clayborg added a comment. Added a test case with a 1 byte .text section that will overflow into the 15 bytes of the .data section that follows. This will test the overflow case that was requested. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

labath accepted this revision. labath added a comment. In D86261#2229341 , @clayborg wrote: > Hopefully this should be good to go, let me know if anyone has any issues. Looks good, just please also add a test case which runs off the end of the text secti

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg added a comment. Hopefully this should be good to go, let me know if anyone has any issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86261/new/ https://reviews.llvm.org/D86261 ___ lldb-comm

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg updated this revision to Diff 286901. clayborg added a comment. Fixed: - Use a safer method to read the data we need for the .text section in case we need and extra 15 bytes. - Rephrase confusing comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:174 + // end of the .text section if the .text section is less than a page size in + // length. + const uint8_t *ptr = text_data.GetDataStart(); clayborg wrote

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:174 + // end of the .text section if the .text section is less than a page size in + // length. + const uint8_t *ptr = text_data.GetDataStart(); I will try and

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

labath added a subscriber: markmentovai. labath added a comment. Also, +@markmentovai, in case he has any thoughts on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86261/new/ https://reviews.llvm.org/D86261 __

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

labath added a comment. This has been a feature we've been missing for a while. Thanks for implementing it. Just two quick requests on the implementation. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:171-174 + // This code carefully duplicates how the

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:559-560 if (!match) { + // Breakpad might put a hash of the up to the first page

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

jhenderson resigned from this revision. jhenderson added a comment. I'm not an LLDB developer, so probably not the right person to review this, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86261/new/ https://reviews.llvm.org/D86261 __

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg created this revision. clayborg added reviewers: labath, jhenderson, aadsm, wallace. Herald added a project: LLDB. clayborg requested review of this revision. Herald added a subscriber: JDevlieghere. Breakpad will always have a UUID for binaries when it creates minidump files. If an ELF