aprantl added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85388/new/
https://reviews.llvm.org/D85388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fccdd5c85d0: [lldb] Fix bug in skipIfRosetta decorator
(authored by JDevlieghere).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85388/new/
https://reviews
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
yes, this makes sense. We could refine the check in future.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85388/new/
https://reviews.llvm.org/D85388
___
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:542
-if not lldbplatformutil.getPlatform() in ['darwin', 'macosx']:
-return "not on macOS"
-if (platform.uname()[5] == "arm") and (self.getArchitecture()
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, friss.
JDevlieghere added a project: LLDB.
JDevlieghere requested review of this revision.
Currently, the `skipIfRosetta` decorator will skip tests with the message "not
on macOS" on non-macOS platforms. This triggers for e
