[Lldb-commits] [PATCH] D85237: [lldb] Add an option to disable TCC

2020-08-04 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. The logic of the patch itself looks fine, but the names, description and commit message are off. A process cannot disable TCC, it's always active. What your patch decides is whether the inferior is responsible for its own TCC permissions. If you don't make the inferior re

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to disable TCC

2020-08-04 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: mib, friss, jasonmolenda. JDevlieghere added a project: LLDB. JDevlieghere requested review of this revision. Add an option to not present the TCC dialog on behalf of the inferior. The motivation is the scenario of running the LLDB