This revision was automatically updated to reflect the committed changes.
Closed by commit rGdb828aba55ac: [lldb][gui] add a test for 'b'
(toggle breakpoint) (authored by llunak).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sounds like it is ok for tests to be here, looks good.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85107/new/
https://reviews.llvm.org/D85107
clayborg added a comment.
lldb/test/API is for testing the public LLDB API functions that are exported as
lldb::SB*. Not sure this belongs here. There was another patch that was moving
things around as well where I commented with the same issue.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACT
llunak updated this revision to Diff 282543.
llunak edited the summary of this revision.
llunak added a comment.
Removed use of curses python module, lldbexpect hardcodes TERM=vt100, so the
escape sequence should be actually hardcoded too. The previous version didn't
work e.g. in Linux console.
llunak created this revision.
llunak added a reviewer: clayborg.
llunak requested review of this revision.
The test needs the python curses module, to get the proper escape sequence to
send the down key event.
I'm not sure if it's ok to just use the module, or if some check for it should
be adde
