[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

2020-07-31 Thread Luboš Luňák via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG77d5a63c191c: [lldb] report an error if a CLI option lacks an argument (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

2020-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84955/new/ https://reviews.llvm.org/D84955 __

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

2020-07-31 Thread Luboš Luňák via Phabricator via lldb-commits
llunak updated this revision to Diff 282208. llunak added a comment. Adjusted according to the comments. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84955/new/ https://reviews.llvm.org/D84955 Files: lldb/test/Shell/Driver/TestError.test lldb/tools/driver

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

2020-07-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Thanks for fixing this. I do have a few comments but the logic looks good. Comment at: lldb/test/Shell/Driver/TestError.test:1 +RUN: not %lldb --arch 2>