[Lldb-commits] [PATCH] D84336: [lldb] Cleanup CommandObject registration (NFC)

2020-07-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2419ded61d97: [lldb] Cleanup CommandObject registration (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D84336?vs=279849&id=279860#toc

[Lldb-commits] [PATCH] D84336: [lldb] Cleanup CommandObject registration (NFC)

2020-07-22 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. I find the macro cleaner than my changes in D84305 . LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84336/new/ https://revie

[Lldb-commits] [PATCH] D84336: [lldb] Cleanup CommandObject registration (NFC)

2020-07-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, mib. - Remove the spurious argument to `CommandObjectScript` - Use make_shared instead of bare `new`. - Hide code duplication behind a macro. Repository: rLLDB LLDB https://reviews.llvm.org/D84336 Files: l