[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

This revision was automatically updated to reflect the committed changes. Closed by commit rGede7c02b38c0: [lldb/COFF] Remove strtab zeroing hack (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83881/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

labath marked 2 inline comments as done. labath added a comment. Thanks for checking this out. Sorry for forgetting you Martin, I'll have to remember to add you to my future coff patches. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:672

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks @mstorsjo for clarifying for me. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:642 DataExtractor symtab_data = ReadI

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

mstorsjo added a comment. In D83881#2153687 , @amccarth wrote: > Yes, getting rid of this hack looks like a good idea. If it was actually > necessary, there should have been a test on it, and the comments should have > been clearer. Well in general, I

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

amccarth added a comment. Yes, getting rid of this hack looks like a good idea. If it was actually necessary, there should have been a test on it, and the comments should have been clearer. See my inline comment, though. It looks like this might back out only part of the change. =

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

labath created this revision. labath added reviewers: amccarth, markmentovai. Herald added a project: LLDB. This code (recently responsible for a unaligned access sanitizer failure) claims that the string table offset zero should result in an empty string. I cannot find any mention of this detail