[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG93ec6cd68426: [lldb] Desugar template specializations (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin updated this revision to Diff 278200. jarin added a comment. Undo the infinite loop detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemC

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

teemperor accepted this revision. teemperor added a comment. I think your comment got broken by Phabricator. I actually think the old code was fine. It's a generic bug that also applies to `Decltype` (which is already implemented), so someone just has to fix the whole function in a follow up pa

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin added a comment. In D83858#2152772 , @teemperor wrote: > This could cause that `RemoveWrappingTypes` goes into an infinite loop under > some situations. Usually this function is reserved for types that are always > 'sugar', but TemplateSpecializati

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin updated this revision to Diff 278173. jarin marked 3 inline comments as done. jarin added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.c

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This could cause that `RemoveWrappingTypes` goes into an infinite loop under some situations. Usually this function is reserved for types that are always 'sugar', but TemplateSpecializat

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Template specializations are not handled in many of the TypeSystemClang methods. For example, GetNumChildren does not handle the TemplateSpecialization type class,