[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa01e956a4: [lldb] on s390x fix override issue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk added a comment. In D83580#2144871 , @serge-sans-paille wrote: > Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Thank you @serge-sans-paille . You're right but I'm unsure if all getters are actually const or not. And I

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille added a comment. Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Looks obviously good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580 __

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an override issue by marking a function as const so that the signature maps to the signature of the function in the base class. This is the original error: In file included from /root/ll