teemperor added inline comments.
Comment at: lldb/include/lldb/API/SBBreakpoint.h:142
+
+ lldb::BreakpointSP GetSP() const;
+
I assume this is WIP code and we already told you that, but we can't expose the
internal `lldb_private::*` classes (or their `lldb::*SP
shivammittal99 added a comment.
@JDevlieghere Sounds good! I'll make the changes and use that for any future
additions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82732/new/
https://reviews.llvm.org/D82732
___
JDevlieghere added a comment.
Given that the SB API is stable I wonder if we should be proactive and have
these new functions return `SBError` instead of a bool so that they can be
extended if we ever to decide to return a useful error.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
shivammittal99 updated this revision to Diff 274625.
shivammittal99 added a comment.
- Extend SBTarget to enable/disable/ignore watchpoints
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82732/new/
https://reviews.llvm.org/D82732
Files:
lldb/bind
shivammittal99 created this revision.
shivammittal99 added reviewers: jingham, teemperor.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Signed-off-by: Shivam Mittal
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D82732
Files:
lldb/include/lldb/API/SB
