[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444 +size_t bufsize = sizeof(processInfo); +if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include echristo wrote: > echristo wrote: > > This is problematic in that sys/sysctl is deprecated on linux (causing > > warnings/

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include This is problematic in that sys/sysctl is deprecated on linux (causing warnings/Werror failures). CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include echristo wrote: > This is problematic in that sys/sysctl is deprecated on linux (causing > warnings/Werror failures). I'm

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444 +size_t bufsize = sizeof(processInfo); +if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &bufsize, NULL, 0) == 0 && bufsize >

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide closed this revision. davide added a comment. commit fd19ddb8f2a2b082f492fc59f7f360adf3495701 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:18:29 2020 -0700 [Apple Silicon] Initial support for Rosetta Translated proc

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide added a comment. In D82491#2112269 , @jasonmolenda wrote: > LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & > P_TRANSLATED) as a boolean, but that's a style pref as much as anything. Fair, let me change that. CHANGES

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & P_TRANSLATED) as a boolean, but that's a style pref as much as anything. CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide created this revision. davide added reviewers: jasonmolenda, aprantl, friss. jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. davide closed this revision. LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_f