miko abandoned this revision.
miko added a comment.
Unittest added in https://reviews.llvm.org/D80995.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80990/new/
https://reviews.llvm.org/D80990
___
lldb-
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Could you add a unit test for this? See the`ScalarTest.cpp` for the other
Scalar tests.
Beside that this LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
labath added a comment.
The fix looks obviously correct, but could you please also add a unit test for
this. I guess this would manifest itself as the inability to roundtrip e.g.
`std::numeric_limits::max()` to a Scalar and back.
It's not required, but if you're interested, it would be nice to
miko created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
In Scalar::operator=(long long) the size of the result was calculated using
sizeof(long) instead of sizeof(long long). On Windows sizeof(long)==4 but
sizeof(long long)==8.
Repository:
rG LLVM G
