[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

2020-05-20 Thread Haibo Huang via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG780d7d77327c: [lldb] Allows customizing libxml2 for darwin (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

2020-05-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

2020-05-19 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that's a lot cleaner. A better way to ensure lldb is not accidentally built without xml support is to set LLDB_ENABLE_LIBXML=On in the cmake config/cache file. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

2020-05-19 Thread Haibo Huang via Phabricator via lldb-commits
hhb updated this revision to Diff 265082. hhb added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Host/CMakeLists.txt lldb/so

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

2020-05-19 Thread Haibo Huang via Phabricator via lldb-commits
hhb updated this revision to Diff 265080. hhb added a comment. Remove endif() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

2020-05-19 Thread Haibo Huang via Phabricator via lldb-commits
hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb updated this revision to Diff 265080. hhb added a comment. hhb edited the summary of this revision. hhb updated this revision to Diff 265082. Remove endif() hhb added a comment. rebase