[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 updated this revision to Diff 264339. mati865 added a comment. With `_GNU_SOURCE` removed I was able to successfully build everything without this diff. I cannot test it today but I believe this updated diff would have fixed the error. It's up to you whether this should be considered as

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 added a comment. Indeed, I'll see if I can build all LLVM related packages without `_GNU_SOURCE`. Otherwise I'll guard it with `#ifndef _GNU_SOURCE` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mstorsjo added a comment. In D7#2039069 , @mati865 wrote: > Perhaps you are building with Clang? > I don't remember the message but GCC emits error about incompatible > definition and declaration of `vasprintf`. I can build it without the patch > an

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 added a comment. Perhaps you are building with Clang? I don't remember the message but GCC emits error about incompatible definition and declaration of `vasprintf`. I can build it without the patch and paste the error if you want. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mstorsjo added reviewers: labath, amccarth, mstorsjo. mstorsjo added a comment. +1 from me on this, I'm ok with this change. I'm a bit curious as I haven't seen any issues regarding this myself though. I wonder if it something very MSYS2-specific, or is the difference in building with gcc vs cla

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 created this revision. mati865 added a project: LLDB. Mingw-w64 provides this function and it has been causing issues for MSYS2 when building lldb. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Ho