[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

2020-05-12 Thread Emre Kultursay via Phabricator via lldb-commits
emrekultursay added a comment. In D79757#2031186 , @labath wrote: > ... > Where do the addresses that we're connecting to come from (the user or lldb > code)? If it's lldb code, maybe we could just replace the relevant > "localhost" names with an explic

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

2020-05-12 Thread Emre Kultursay via Phabricator via lldb-commits
emrekultursay updated this revision to Diff 263599. emrekultursay added a comment. Enforce IPv4 usage only in Android code, revert non-Android changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 Files:

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

2020-05-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Getaddrinfo documentation says: Normally, the application should try using the addresses in the order in which they are returned. The sorting function used within getaddrinfo() is defined in RFC 3484; the order can be tweaked for a particular system by e

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

2020-05-11 Thread Emre Kultursay via Phabricator via lldb-commits
emrekultursay updated this revision to Diff 263327. emrekultursay added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 Files: lldb/source/Host/common/TCPSocket.cpp Ind

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

2020-05-11 Thread Emre Kultursay via Phabricator via lldb-commits
emrekultursay created this revision. Herald added subscribers: lldb-commits, mgrang. Herald added a project: LLDB. When connecting to Android, LLDB calls adb#Shell 5 times. At each call, a TCP connection to "localhost:port" needs to be established. On hosts that support IPv4 and IPv6, the "localho