[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

omjavaid added a comment. This breaks on arm-linux. I am going remove arm temporarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79491/new/ https://reviews.llvm.org/D79491 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

dblaikie added a comment. @vsk (assuming you're the original author of this test - couldn't quite figure out the revision history, sorry) - could you check if some of this could be simplified a bit to make it more clear what's being tested/what's "interesting" here? (I've provided some inline c

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c23179826a: [lldb] Revive TestBasicEntryValuesX86_64 (authored by labath). Changed prior to commit: https://reviews.llvm.org/D79491?vs=262595&id=263176#toc Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked an inline comment as done. labath added a comment. In D79491#2024849 , @djtodoro wrote: > I see.. Enabling it only for specific OSes could be a temp solution, but we > can discuss about that. > > > A different way to address this would be t

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro accepted this revision. djtodoro added a comment. > It'd be nice to have a skipUnlessEntryValuesSupportedArch decorator, but I > don't think that has to be folded into this change. OK. I agree. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, thanks. It'd be nice to have a skipUnlessEntryValuesSupportedArch decorator, but I don't think that has to be folded into this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro added a comment. In D79491#2024771 , @labath wrote: > In D79491#2024647 , @djtodoro wrote: > > > Thanks a lot for this! > > > > > Nevertheless, I am still interested in making assembly-based tests for > >

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py:5 + +supported_archs = ["x86_64", "arm", "aarch64"] + djtodoro wrote: > I haven't refresh

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked an inline comment as done. labath added a comment. In D79491#2024647 , @djtodoro wrote: > Thanks a lot for this! > > > Nevertheless, I am still interested in making assembly-based tests for this > > (and similar features) because it enables

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro added inline comments. Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py:5 + +supported_archs = ["x86_64", "arm", "aarch64"] + I haven't refreshed the page before submitting my previous comment. WDYT

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath updated this revision to Diff 262595. labath marked an inline comment as done. labath added a comment. - make the test architecture-independent (and rename accordingly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79491/new/ https://reviews

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked 6 inline comments as done. labath added inline comments. Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:21-22 + ++global; //% self.filecheck("image lookup -va $pc", "main.cpp", "-check-prefix=FUNC1-DESC") // FU

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro added a comment. Thanks a lot for this! > Nevertheless, I am still interested in making assembly-based tests for this > (and similar features) because it enables testing scenarios that we could not > get (reliably or at all) a compiler to produce. I also think this would be more stabl

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

vsk added a comment. Thanks for working on this! Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:21-22 + ++global; //% self.filecheck("image lookup -va $pc", "main.cpp", "-check-prefix=FUNC1-DESC") // FUNC1-DESC: name = "si

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked 2 inline comments as done. labath added a comment. I should note that I did look into making an assembly file out of this, but that turned out to be more complicated than I expected and then David convinced me that it should be possible to write this in a way that prevents the opt

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath created this revision. labath added reviewers: vsk, djtodoro, dblaikie. Herald added a project: LLDB. This function rewrites the test to be (hopefully) less susceptible to codegen changes and re-enables it. The most interesting changes are: - use an __attribute__((optnone)) function inste