This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf5ed6dc59ec: Fix error handling after [] in
'frame variable' (authored by jarin, committed by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
teemperor accepted this revision.
teemperor added a comment.
I don't think I know this code better than Pavel, but this also LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79404/new/
https://reviews.llvm.org/D79404
_
jarin added a comment.
Do you think Raphael would want to review this as well? If you think it is not
necessary, could you land the patch for me?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79404/new/
https://reviews.llvm.org/D79404
_
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79404/new/
https://reviews.llvm.org/D79404
_
jarin created this revision.
jarin added reviewers: teemperor, labath.
Herald added subscribers: lldb-commits, arphaman.
Herald added a project: LLDB.
jarin retitled this revision from "Fix handling of [] in 'frame
variable'" to "Fix error handling after [] in 'frame variable'".
This fixes a bug
