[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c08b7eac16: Move the Xcode SDK path caching to HostInfo (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79364?vs=262184&id=262471#toc Repositor

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

labath added a comment. I think this is right, but it looks like you uploaded a diff based on the previous version of the patch instead of the master. In D79364#2020728 , @aprantl wrote: > Good point! The reason why I went with `Platform::GetHostPlatform

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

aprantl updated this revision to Diff 262184. aprantl added a comment. Removed the Platform detour. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79364/new/ https://reviews.llvm.org/D79364 Files: lldb/include/lldb/Target/Platform.h lldb/source/Core/Module.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

aprantl marked an inline comment as done. aprantl added a comment. In D79364#2019818 , @labath wrote: > Since the option of going to the "host platform" was discussed already and > rejected, I think a new discussion is in order before going back to it. Wh

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

labath added a comment. Since the option of going to the "host platform" was discussed already and rejected, I think a new discussion is in order before going back to it. What are the exact circumstances where you did not get a PlatformDarwin object? Note that I am not opposed (and I never was)

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the inline comment. Comment at: lldb/include/lldb/Host/HostInfoBase.h:96 /// Return the directory containing a specific Xcode SDK. - static std::s

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. Herald added a subscriber: fedor.sergeev. aprantl added a parent revision: D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units. When debugging a remote platform, the platform you get from