This revision was automatically updated to reflect the committed changes.
Closed by commit rG664fda72eaa3: Fix setting Python3_ROOT_DIR on Windows
(authored by isuruf).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77842/new/
https://reviews.llvm.or
teemperor added a comment.
@isuruf Do you have commit access or do you need this committed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77842/new/
https://reviews.llvm.org/D77842
___
lldb-commits mai
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, PYTHON_HOME is apparently the Windows way we allow people to specify the
python root when finding the package.
Please update the review description though with why this change was
isuruf added a comment.
The intention of the code is to set the variable `Python3_ROOT_DIR` to the
value of the variable `PYTHON_HOME`, but it was using just the string
`"PYTHON_HOME"` instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77842/n
JDevlieghere added a comment.
Can you explain why this is necessary?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77842/new/
https://reviews.llvm.org/D77842
___
lldb-commits mailing list
lldb-commits@
isuruf created this revision.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
isuruf added a reviewer: LLDB.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77842
Files:
lldb/cmake/modules/FindPythonInterpAndLibs.cmake
Index: lldb/cmake/modules/F
