jarin added a comment.
Abandoning the patch since we cannot reach agreement on how this should be
tested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77765/new/
https://reviews.llvm.org/D77765
___
l
jarin added a comment.
As labath@ suggested, I have teased apart the test and the testability
refactoring into a separate patch. The patch lives at
https://reviews.llvm.org/D77790, could you please take a look?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
labath added a comment.
Thanks for tackling this. I believe this should be split into two patches: an
NFC patch which makes it possible to unit test this code, and then a follow-up
patch to fix the actual bug. The first patch can include the general testing
infrastructure, and a some tests for
jarin added a comment.
I rewrote parts of the test, hopefully making it a bit clearer. Please let me
know if this made it better.
Comment at: lldb/source/Target/Memory.cpp:23-24
// MemoryCache constructor
-MemoryCache::MemoryCache(Process &process)
+MemoryCache::MemoryCache(M
jarin updated this revision to Diff 256207.
jarin marked 10 inline comments as done.
jarin added a comment.
Addressed some of the reviewer comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77765/new/
https://reviews.llvm.org/D77765
Files:
clayborg added a comment.
I am not a pro at the gtest stuff, but this was very hard to follow and figure
out what these tests are doing.
Comment at: lldb/source/Target/Memory.cpp:23-24
// MemoryCache constructor
-MemoryCache::MemoryCache(Process &process)
+MemoryCache::Memory
jarin created this revision.
jarin added reviewers: labath, clayborg.
jarin added a project: LLDB.
Herald added subscribers: lldb-commits, mgorny.
jarin retitled this revision from "Fix incorrect L1 cache flushing" to "Fix
incorrect L1 inferior memory cache flushing".
As discussed in https://revi
