[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG1893065d7bf5: Allow the ThreadPlanStackMap to hold the thread plans for threads that were not… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham added a comment. In D76814#1958988 , @labath wrote: > Looks fine to me, though I can't say I'm much of a thread plan expert (but > then again, I don't know if anyone except you is). That's not a great situation, but it is where we currently are.

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me, though I can't say I'm much of a thread plan expert (but then again, I don't know if anyone except you is). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham updated this revision to Diff 254664. jingham added a comment. I changed target.process.plugin-reports-all-threads to target.experimental.os-plugin-reports-all-threads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76814/new/ https://revie

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-reports-all-threads", "Boolean">, +Glob

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham marked 5 inline comments as done. jingham added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-r

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham updated this revision to Diff 254372. jingham added a comment. Add a variable backing the std::condition_variable in the source for the stepping test to catch spurious wakeups. AssertTrue -> AssertIn in the ThreadPlanList test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-reports-all-threads", "Boolean">, +Glob

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham marked 2 inline comments as done. jingham added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-r

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-reports-all-threads", "Boolean">, +Glob

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham added a comment. Addressed most of the review comments. I don't see that using file check would make the plan output checking any easier. The current function seems clear and easy to use. Trying to dynamically insert the passed in matches into a filecheck test file and then run file

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham updated this revision to Diff 252982. jingham marked 2 inline comments as done. jingham added a comment. Addressed most of Pavel's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76814/new/ https://reviews.llvm.org/D76814 Fi

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added a comment. I still don't know much about thread plans, but I didn't see anything that would stand out. All my comments are fairly superficial. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham created this revision. jingham added reviewers: clayborg, labath, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham added a parent revision: D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID. This is the final patch