[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG865996ddf626: [lldb] Remove m_last_file_sp from SourceManager (authored by emrekultursay, committed by labath). Changed prior to commit: https://reviews.llvm.org/D76806?vs=256416&id=258738#toc Reposito

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D76806#1973035 , @emrekultursay wrote: > Thanks for noticing the test breakages Pavel. I fixed the bug, and verified > that the tests you mentione

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. Thanks for noticing the test breakages Pavel. I fixed the bug, and verified that the tests you mentioned pass. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 __

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 256416. emrekultursay added a comment. Fix broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManager.h lldb/so

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I am afraid that the last patch in this series introduces a bunch of failures for me. The failures appear to be more-or-less consistent, but the impacted tests seem pretty random:

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. I don't have commit access, can someone with access commit all three approved CLs in this stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 ___

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 254292. emrekultursay added a comment. Fix missing use of GetLastFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManage

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

jingham accepted this revision. jingham added a comment. There was one missing use of GetLastFile (as opposed to doing it by hand.) Getting the default file is not used in any performance critical way that I'm aware of. It's mostly used for "break set -l" with no "-f" and list with no argument

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 254241. emrekultursay marked an inline comment as done. emrekultursay added a comment. use assertGreater instead of assertTrue(x>y) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine now. Jim, do you have any more thoughts on this patchset? Comment at: lldb/test/API/commands/settings/use_source_cache/TestUseSourceCache.py:40 +

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253651. emrekultursay added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManager.h lldb/sour

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253648. emrekultursay marked 6 inline comments as done. emrekultursay added a comment. PTAL. Applied suggested changes, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ http

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath added inline comments. Comment at: lldb/test/API/commands/settings/use_source_cache/TestUseSourceCache.py:17 + +@skipIf(oslist=no_match(["windows"])) +def test_set_use_source_cache_false(self): Could you remove this decorator? The test is not extr

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253260. emrekultursay added a comment. Cleanup the Python test to make it a bit more readable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/includ

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253254. emrekultursay added a comment. Added test that verifies end-to-end impact of "setting set use_source_cache false" on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://revie

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252888. emrekultursay added a comment. Applied suggestions from labath@ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceMana

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay marked 3 inline comments as done. emrekultursay added a comment. In D76806#1943062 , @labath wrote: > It's not clear to me what is the user-visible effect of this. It sounds like > there should be one, but I don't know what it is... If LLD

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath added reviewers: labath, jingham. labath added a comment. It's not clear to me what is the user-visible effect of this. It sounds like there should be one, but I don't know what it is... Comment at: lldb/source/Core/SourceManager.cpp:175-176 - if (m_last_file_sp.get(

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...and replace it with m_last_file_spec instead. When Source Cache is enabled, the value stored in m_last_file_sp is already in the Source Cache, and caching it again in SourceManager bring