This revision was automatically updated to reflect the committed changes.
Closed by commit rGacae69d08c88: [lldb] Add new LLDB setting: use-source-cache
(authored by emrekultursay, committed by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7
emrekultursay added a comment.
I added an end-to-end test to the entire use-source-cache feature in
https://reviews.llvm.org/D76806
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76804/new/
https://reviews.llvm.org/D76804
___
emrekultursay updated this revision to Diff 253013.
emrekultursay added a comment.
- Apply code review comments from labath@
- Wipe source cache when user sets the property to false
- Also expose set/get methods for use-source-cache in SBDebugger
Repository:
rG LLVM Github Monorepo
CHANGES SI
labath added a reviewer: jingham.
labath added a comment.
Yeah, the differences between windows&posix handling of memory mapped files is
quite annoying (though I can't really say that the windows behavior is worse
than randomly sending out SIGBUSes).
The alternative (which is used in other tool
emrekultursay added a comment.
I did not see any existing tests that validate setting/reading of properties.
Can you point to me if you know any that exists?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76804/new/
https://reviews.llvm.org/D76804
JDevlieghere added a comment.
Testing the effect of this change might be hard, but please add or extend an
existing test to check that you can set and read the new property.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76804/new/
https://reviews.
emrekultursay created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
emrekultursay added a child revision: D76805: Fix
SourceManager::SourceFileCache insertion.
LLDB memory-maps large source files, and at the same time, caches
all source files in the Source
