This revision was automatically updated to reflect the committed changes.
Closed by commit rGa567d6809e15: [DataFormatters] Add formatter for libc++
std::unique_ptr (authored by shafik).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D76476?vs=251783&id=252112#t
shafik updated this revision to Diff 251783.
shafik marked an inline comment as done.
shafik added a comment.
Adding addition tests for references
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76476/new/
https://reviews.llvm.org/D76476
Files:
lldb/include/lldb/DataFormatters/Formatte
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM with some added test coverage. Jim?
Comment at:
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/main.cpp:9
+ std::unique_ptr up_int = std::
shafik added inline comments.
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:618
+ "unique_ptr synthetic children",
+ ConstString("^(std::__[[:alnum:]]+::)unique_ptr<.+>(( )?&)?$"),
+ stl_synth_flags, true);
vsk wrote:
> D
shafik updated this revision to Diff 251707.
shafik marked 4 inline comments as done.
shafik added a comment.
Addressing comments on naming and not duplicating the regex
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76476/new/
https://reviews.llvm.org/D76476
Files:
lldb/include/lldb/
vsk added a comment.
Awesome :)
Comment at: lldb/include/lldb/DataFormatters/FormattersHelpers.h:59
+lldb::ValueObjectSP GetValueOfCompressedPair(ValueObject &pair);
+
Mind adding ‘libcxx’ somewhere in the function name, to avoid confusion?
shafik created this revision.
shafik added reviewers: vsk, jingham.
This adds a formatter for libc++ `std::unique_ptr`. We currently already have
formatters for `std::shared_ptr` and `std::weak_ptr`.
I also refactored `GetValueOfCompressedPair(...)` out of `LibCxxList.cpp` since
I need the same
