[Lldb-commits] [PATCH] D76216: Improve step over performance

This revision was automatically updated to reflect the committed changes. Closed by commit rG089cfe113da1: Improve step over performance (authored by jarin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://revie

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin added a comment. Pavel or Jim, could you possibly land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D76216: Improve step over performance

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sorry, forgot to select the action... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216

[Lldb-commits] [PATCH] D76216: Improve step over performance

labath added a comment. In D76216#1930689 , @jarin wrote: > I also see that build-bot is not happy about my patch. Clang-tidy somewhat > mysteriously fails on missing lldb/Target/ThreadPlanStepOverRange.h, which I > did not touch at all (neither the fail

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin added a comment. Thanks Greg, I will wait for Jim's comment. I also see that build-bot is not happy about my patch. Clang-tidy somewhat mysteriously fails on missing lldb/Target/ThreadPlanStepOverRange.h, which I did not touch at all (neither the fail nor the #include). Any idea what that

[Lldb-commits] [PATCH] D76216: Improve step over performance

clayborg added a comment. Jim is the one that really needs to mark this as accepted as the thread plans are one of his many areas of expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 ___

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin updated this revision to Diff 251208. jarin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 Files: lldb/source/Target/ThreadPlanStepOverRange.cpp Index: lldb/source/Target/

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin added a comment. Thanks for all the clarifications, this is very useful. I have always wanted to learn about thread plans, and this was a nice opportunity to do that. The extra background from you guys is a nice bonus. Regarding the patch itself, is there anything preventing an LGTM? Re

[Lldb-commits] [PATCH] D76216: Improve step over performance

jingham added a comment. This looks fine to me. The thread plans are self-healing, in the sense that they always check after every stop whether they are still relevant, (IsStale) and unship themselves if they aren't. For instance, if a step-over plan finds that the stack has unwound past its

[Lldb-commits] [PATCH] D76216: Improve step over performance

labath added a reviewer: jingham. labath added a comment. This seems reasonable, but let's wait for Greg and Jim's oppinions. Comment at: lldb/source/Target/ThreadPlanStepOverRange.cpp:176 +// rely on that breakpoint to trigger once we return to the range. +if (

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Target/ThreadPlanStepOverRange.cpp:176 +// rely on that breakpoint to trigger once we return to the range. +if (m_next_branch_bp_sp) + return false; -

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin created this revision. jarin added reviewers: clayborg, labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This patch improves step over performance for the case when we are stepping over a call with a next-branch-breakpoint (see https://reviews.llvm.org/D58678),