[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

This revision was automatically updated to reflect the committed changes. Closed by commit rG714324b79ae2: [DebugInfo] Support DWARFv5 index sections. (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.ll

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie accepted this revision. dblaikie added a comment. In D75929#1954443 , @labath wrote: > Thanks for doing this. This looks fine to me. @dblaikie, @jhenderson, do you > have any additional comments? nah, nothing dire that comes to mind - thanks fo

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 254207. ikudrin marked an inline comment as done. ikudrin added a comment. Thanks, @jhenderson, @labath! - Added a helper function `isKnownV5SectionID()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 Fil

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson accepted this revision. jhenderson added a comment. Nothing else from me, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this. This looks fine to me. @dblaikie, @jhenderson, do you have any additional comments? Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp:38-39 + i

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 253874. ikudrin marked 4 inline comments as done. ikudrin added a comment. - Updated the comment for `DWARFSectionKind`. - Simplified the storing of raw section identifiers. - Moved independent changes into separate patches. CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 253879. ikudrin added a comment. - Removed `DWARFUnitIndex::getVersion()` as it is related to the other patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 Files: llvm/include/llvm/BinaryFormat/Dwarf.de

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1928964 , @ikudrin wrote: > In D75929#1926834 , @labath wrote: > > > (btw, is there a test case for the "unknown column" code path?) > > > Yes, it is checked in > `llvm/test/DebugI

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:47-48 +// For pre-standard ones, which correspond to sections being deprecated in +// DWARFv5, the values are chosen more or less arbitrary and a tag "_EXT_" +// is added to the names.

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin marked 2 inline comments as done. ikudrin added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:47-48 +// For pre-standard ones, which correspond to sections being deprecated in +// DWARFv5, the values are chosen more or less arbitrary and

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:47-48 +// For pre-standard ones, which correspond to sections being deprecated in +// DWARFv5, the values are chosen more or less arbitrary and a tag "_EXT_" +// is added to the names.

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin marked 3 inline comments as done. ikudrin added a comment. In D75929#1926834 , @labath wrote: > (btw, is there a test case for the "unknown column" code path?) Yes, it is checked in `llvm/test/DebugInfo/X86/debug-cu-index-unknown-section.s`, whi

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added a comment. Side note: This has become complicated enough it might be worth separating these patches now rather than later - changes to dumping should be separate from changes to llvm-dwp, for instance. In D75929#1926834 , @labath wrote: >

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1924373 , @ikudrin wrote: > @dblaikie, @labath, as far as I can understand, the patch complies with your > vision. The main difference is that the enum is still intended for internal > use only, but it probably should no

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson added a comment. Thanks. My comments have all been addressed. I'm happy once somebody else looks at the more technical aspects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 ___ lldb-co

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 250731. ikudrin marked 8 inline comments as done. ikudrin added a comment. - Fixed messages in `llvm-dwp.cpp`. - Fixed comments in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 Files: lldb/sou

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added inline comments. Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:614 +if (CUIndex.getVersion() != 2) + return make_error("Unsupported cu_index version"); jhenderson wrote: > jhenderson wrote: > > I see the above error message starts with a c

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson added inline comments. Comment at: llvm/test/DebugInfo/X86/dwp-v5-cu-index.s:1 +## The test checks that we can parse and dump a CU index section that compliant +## to the DWARFv5 standard. that is compliant Comment at: llvm/test/Debu

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 250537. ikudrin marked 10 inline comments as done. ikudrin added a comment. @jhenderson, thank you for the comments! - Made comments for `DWARFSectionKind`, `serializeSectionKind()` and `deserializeSectionKind()` in doxygen style. - Renamed function. - Fixed

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:116 + // This is a parallel array of raw section IDs for columns of unknown kinds. + // This array is created only if there are items in columns ColumnKinds with + // DW_SECT_EXT_unkn

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson added a comment. I'm not really up to speed with the .debug_*_index sections, so I haven't looked really at the overall approach. I've just provided some basic stylistic comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:22 +// Pre-standard

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added a comment. In D75929#1920691 , @dblaikie wrote: > > This is almost what you are doing right now -- the only difference is that > > the "internal" enum would no longer be internal -- it would actually match > > the on-disk format of a v5 ind

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added a comment. > This is almost what you are doing right now -- the only difference is that > the "internal" enum would no longer be internal -- it would actually match > the on-disk format of a v5 index. This v5 enum would contain the official > DWARFv5 constants as well as the new

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 249939. ikudrin added a comment. - Use values for clashing identifiers proposed by @dblaikie. - Convert all unknown section identifiers into a special value, `DW_SECT_EXT_unknown`; Use an optional parallel array to keep the raw values of unknown identifiers.

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added a comment. In D75929#1916466 , @labath wrote: > In D75929#1916127 , @ikudrin wrote: > > > I believe that this patch is more or less compatible with any approach > > which might be taken. The idea is t

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added a comment. Thanks for the links! What a coincidence... I believe that this patch is more or less compatible with any approach which might be taken. The idea is that there is a set of constants for internal use and functions to translate them to/from external representation and bot

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1916760 , @ikudrin wrote: > In D75929#1916466 , @labath wrote: > > > That's true, but I'm not sure it is really the best solution. > > > Well, I do not pretend this to be a perfect

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1916127 , @ikudrin wrote: > I believe that this patch is more or less compatible with any approach which > might be taken. The idea is that there is a set of constants for internal use > and functions to translate them t

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added a comment. In D75929#1915009 , @labath wrote: > I haven't digested the patch yet, but I am wondering if you've seen the > recent discussion (`DWP mixed (DWARFv4/pre-standard + DWARFv5) content`) on > dwarf-discuss (link1 >

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin created this revision. ikudrin added reviewers: dblaikie, probinson, jhenderson, aprantl, labath. ikudrin added projects: LLVM, debug-info. Herald added subscribers: lldb-commits, arphaman, hiraditya. Herald added a project: LLDB. DWARFv5 defines index sections in package files in a slight

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. I haven't digested the patch yet, but I am wondering if you've seen the recent discussion (`DWP mixed (DWARFv4/pre-standard + DWARFv5) content`) on dwarf-discuss (link1 , link2