This revision was automatically updated to reflect the committed changes.
Closed by commit rG59d816d88464: Correctly identify iOS simulator processes in
debugserver. (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D75696?vs=248634&id=248776
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: lldb/test/API/functionalities/gdb_remote_client/TestWasm.py:35
-if packet == "qProcessInfo":
-return self.qProcessInfo()
if packet[0:13] == "qRegisterInfo":
-
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Overall looks fine, Fred's comment is correct, nb you want to test it with `#if
TARGET_OS_OSX == 1`, it's always defined either to 0 or 1.
Comment at: lldb/test/
friss added inline comments.
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:601-607
+static bool IsMacOSHost() {
+ static uint32_t g_host_cputype = 0;
+ size_t len = sizeof(uint32_t);
+ if (!g_host_cputype)
+::sysctlbyname("hw.cputype", &g_host_cputype, &l
aprantl updated this revision to Diff 248634.
aprantl added a comment.
Here is a more principled variant of the patch. I pushed the logic down to
debugserver, so we don't need to guess or fixup anything in LLDB.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75696/new/
https://reviews.l
aprantl created this revision.
aprantl added reviewers: jasonmolenda, friss.
Herald added subscribers: aheejin, sbc100.
This patch detects when an ios process runs on a macOS host and
updates the target triple with the "simulator" environment.
This is part of https://bugs.swift.org/browse/SR-1197
