[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

2020-03-06 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG71c1c184744c: [lldb] Delete UnwindMacOSXFrameBackchain (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75680/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

2020-03-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D75680#1908368 , @xiaobai wrote: > If UnwindLLDB is //the// unwinder, that makes things a little easier for > plugin separation. Yep, I think that after this we can just move UnwindLLDB into the core libraries. But that is a

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

2020-03-05 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. LGTM. If UnwindLLDB is //the// unwinder, that makes things a little easier for plugin separation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75680/new/ https://reviews.llvm.org/D75680

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

2020-03-05 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. The only time this plugin gets activated is when there's been some problem with the arch triple and we end up defaulting to this unwinder, which never works anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

2020-03-05 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: jasonmolenda, JDevlieghere, xiaobai. Herald added subscribers: fedor.sergeev, krytarowski, mgorny, jyknight. Herald added a project: LLDB. It isn't used anywhere (except on imaginary triples like sparc-apple-ios) and it also violates plugin sep