[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha added a comment. `platform.module-cache-directory` should be fixed by rGfe74df01a909 . Regarding `script-lang`, its default value is `eScriptLanguagePython` in CoreProperties.td and I'm not sure that I should

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. Fixed in 352f16db87f583ec7f55f8028647b5fd8616111f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. Sure, I can take care of it. It seems `OptionValueRegex::Clear` is always resetting to an empty regex. I guess the same goes for the other option values that are failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D755

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha added a comment. Thank you for details, I'm looking at these failures, however, I'm not able to debug on the macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 _

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. I guess now all the shady hacks are coming out. The following settings change their value after calling settings clear after startup in the test: target.process.thread.step-avoid-regexp (regex) -> from '^std::' to empty string platform.module-cache-directory (file

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. Somehow this broke the macOS LLDB bot: Failing Tests (2): lldb-api :: functionalities/inline-stepping/TestInlineStepping.py lldb-api :: lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf90a15b1ac9: [lldb] Clear all settings during a test's setUp (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ http

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome, thanks. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 ___

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 249902. tatyana-krasnukha added a comment. Addressed comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py ll

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectSettings.cpp:1119-1122 +if (m_options.m_clear_all) { + GetDebugger().GetValueProperties()->Clear(); + return result.Succeeded(); +} What will happen if I pass both `--al

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 248404. tatyana-krasnukha added a comment. Removed TestFixIts.py as those changes relate to the parent revision. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: l

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 248213. tatyana-krasnukha added a comment. Added `--all` property to `settings clear` + added a test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: lldb/packages

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

labath added a reviewer: jingham. labath added a subscriber: jingham. labath added a comment. Clearing all settings is a reasonable operation, so I don't have any problem with it per se. I'm just wondering, given that this is not something that one would want to do very often (and it can have ca

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha added a parent revision: D74903: [lldb][testsuite] Create a SBDebugger instance for each test. Move