[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yea, I guess I spoke too soon when I said the fix is going to be easy -- this is quite messy. I believe I understand now why we haven't run into this problem before . Lldb default cache size

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

teemperor added a comment. This fixes the asan failures for me, so LGTM. Don't really know that code so someone else should approve this. I skipped the test on the sanitizer build for now ( 56b03c35ddecf7d096a513b0633ddf6c49286784

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

paolosev added a comment. The Harbormaster errors don't seem to be real failures: /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/lldb/source/Core/Module.cpp:9:10: error: 'lldb/Core/Module.h' file not found [clang-diagnostic-error] #include "lldb/Core/Module.h" ^ /

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

paolosev updated this revision to Diff 246868. paolosev added a comment. In D75200#1894162 , @clayborg wrote: > Not sure this is the right fix. The calling code should listen to how many > bytes were actually read from memory and avoid touching any bytes.

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

clayborg added a comment. Not sure this is the right fix. The calling code should listen to how many bytes were actually read from memory and avoid touching any bytes. So we should fix Module::GetMemoryObjectFile to resize its buffer back to only the size that was read. Something like: const

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

paolosev created this revision. paolosev added reviewers: labath, vsk, JDevlieghere, clayborg. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin. The original discussion for this issues is here . The lldb sanitized b