labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
All of this code you're adding to Process.cpp is extremely specific to one
platform's notion of "crash info". This should be factored out so that
macos-specific details live inside s
teemperor added a comment.
I have some comments (beside my usual documentation spam). But otherwise looks
good to me.
Comment at: lldb/bindings/interface/SBProcess.i:196
+SBStructuredData
+GetCrashInfo ();
+
documentation.
Comment at
mib updated this revision to Diff 244793.
mib added a comment.
Run clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74657/new/
https://reviews.llvm.org/D74657
Files:
lldb/bindings/interface/SBProcess.i
lldb/include/lldb/API/SBProcess
mib created this revision.
mib added reviewers: JDevlieghere, friss, jingham.
mib added a project: LLDB.
Herald added a subscriber: lldb-commits.
Currently, in macOS, when a process crashes, lldb halts inside the
implementation
disassembly without yielding any useful information. The only way to
