[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

2020-02-18 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha closed this revision. tatyana-krasnukha added a comment. Closed by commit b624b7dfd087 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74558/new/ https://reviews.llvm.org/D74

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

2020-02-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Targets and Breakpoints should only ever be managed by SP in lldb, so enforcing that seems like a good cleanup. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

2020-02-13 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, abidh. The idea is: the fewer classes make an assumption that a target object is already managed by a shared_ptr -