[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

2020-02-07 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd62c9cecf34: [lldb-vscode] remove deprecated trace option (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

2020-02-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Originally this was going to enable logging to "/tmp/vscode.txt", but it is hard to log something when many packets have already gone by before sending the "launch" or "attach" requests. S

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

2020-02-07 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This option is not used anymore and has been replaced by the env var LLDBVSCODE_LOG. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74266