[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

2020-02-07 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc832e82cd9d8: [lldb-vscode] disable completions (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74264/new/

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

2020-02-07 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. > These completion requests are also expected to be asynchronous right? Do we > have any support for this right now? Currently we will deadlock in > lldb-vscode handling the current completion until it completes right? To > properly handle completion, we will need to be

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

2020-02-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. These completion requests are also expected to be asynchronous right? Do we have any support for this right now? Currently we will deadlock in lldb-vscode handling the current completion until it completes right? To properly handle completion, we will need to be able t

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

2020-02-07 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Completion requests are causing some problems in the debugger, which is explained in the comment in the code. I'm disabling it for now until we have time to do