kwk requested changes to this revision.
kwk added a comment.
This revision now requires changes to proceed.
I agree with @friss that there is a change in behavior. I'm not sure it is
fixable with what I wrote but I think so.
Comment at: lldb/include/lldb/Target/Language.h:191
mib added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+ bool IsMangledName(llvm::StringRef name) const override {
+return false;
+ }
friss wrote:
> shafik wrote:
> > xiaobai wrote:
> > > friss wrote:
> > > > The origi
friss added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+ bool IsMangledName(llvm::StringRef name) const override {
+return false;
+ }
shafik wrote:
> xiaobai wrote:
> > friss wrote:
> > > The original code was callin
shafik added subscribers: mib, shafik.
shafik added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+ bool IsMangledName(llvm::StringRef name) const override {
+return false;
+ }
xiaobai wrote:
> friss wrote:
> > The orig
xiaobai added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+ bool IsMangledName(llvm::StringRef name) const override {
+return false;
+ }
friss wrote:
> The original code was calling `IsPossibleObjCMethodName` and it l
friss added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+ bool IsMangledName(llvm::StringRef name) const override {
+return false;
+ }
The original code was calling `IsPossibleObjCMethodName` and it looks like you
co
xiaobai marked an inline comment as done.
xiaobai added a comment.
I uploaded this patch primarily to get some feedback on possible alternatives
because I'm not happy creating a dependency from `Core` to `Target` here.
Suggestions welcome!
Comment at: lldb/source/Core/Mangled
xiaobai created this revision.
xiaobai added a reviewer: LLDB.
Herald added a project: LLDB.
Instead of asking each of the language plugins directly if a symbol is a
possible manghled name for that language, we can generalize this
pattern. By adding a method `IsMangledName` and iterating over each
