[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

This revision was automatically updated to reflect the committed changes. Closed by commit rG363f05b83d9c: [lldb] Delete the SharingPtr class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D74153?vs=242974&id=243808#toc Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

jingham added a comment. In D74153#1862554 , @labath wrote: > Actually, it looks like we were getting away with that because the whole > ValueObjectRegisterContext (*not* RegisterSet) class is unused. In fact the > whole concept of having the entire regi

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

labath added a comment. Actually, it looks like we were getting away with that because the whole ValueObjectRegisterContext (*not* RegisterSet) class is unused. In fact the whole concept of having the entire register context as a "value" seems fairly odd to me. Can we just delete it? Reposito

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

jingham added a comment. We were probably getting away with this because ValueObjectRegisterSet's children don't really need their parent to construct their values? But still, this is not how ValueObject children should work... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

jingham added a comment. I think the ValueObjectRegisterSet::CreateChildAtIndex was wrong originally. It doesn't make it's children by passing itself in as the parent of the child, but just makes an independent ValueObject. You can fix that in your version by passing the ValueObjectRegisterSe

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Very nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74153/new/ https://reviews.llvm.org/D74153 _

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

labath updated this revision to Diff 242974. labath added a comment. Remove the leftover mutex unlock in the ClusterManager destructor. Doing any operation on the object while it is being destroyed is not safe, and the mutex will not help there. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

labath created this revision. labath added reviewers: teemperor, JDevlieghere, jingham. Herald added subscribers: jfb, mgorny. Herald added a project: LLDB. The only use of this class was to implement the SharedCluster of ValueObjects. However, the same functionality can be implemented using a reg