[Lldb-commits] [PATCH] D74001: Fix after c25938d

2020-02-04 Thread Adrian McCarthy via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0d2d455f56: Fix after c25938d (authored by amccarth). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D74001?vs=242440&id=242465#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D74001: Fix after c25938d

2020-02-04 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks great to me, thanks! If it's easy to add on, could you remove the xfail from lldb/packages/Python/lldbsuite/test/commands/add-dsym/uuid/TestAddDsymCommand.py in the sa

[Lldb-commits] [PATCH] D74001: Fix after c25938d

2020-02-04 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth created this revision. amccarth added reviewers: jasonmolenda, clayborg. My refactor caused some changes in error reporting that TestAddDsymCommand.py was checking, so this restores some of the changes to preserve the old behavior. Putting this through review rather than committing dire