[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yes, standalone patches are the way to go. To help you, I've tried to annotate the various assertions, what kind of problems they could cause, and possible testing strategies. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:71

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-25 Thread Ayke via Phabricator via lldb-commits
aykevl abandoned this revision. aykevl added a comment. Closing this one. Maybe there is something useful in this patch but if there is, I'll submit that in a standalone (more focused) patch. The majority of it has been merged in D73969 . Repository: rG LLVM

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D73961#1860270 , @aykevl wrote: > > How do you normally generate the binaries with these kinds of addresses? > > Can they be produced with clang? Can they be produced with llvm-mc? Linked > > with lld ? > > With `avr-gcc`. I th

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-05 Thread Ayke via Phabricator via lldb-commits
aykevl added a comment. > How do you normally generate the binaries with these kinds of addresses? Can > they be produced with clang? Can they be produced with llvm-mc? Linked with > lld ? With `avr-gcc`. I think it's easiest to just generate a minimal binary using `yaml2obj`. For the rest I'

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. You should be able to test most (if not all) of this stuff without an actual process. lldb can display global variables, set breakpoints, resolve addresses, etc. without being connected to a debug stub. How do you normally generate the binaries with these kinds of addres

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-04 Thread Ayke via Phabricator via lldb-commits
aykevl added a comment. See D73969 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73961/new/ https://reviews.llvm.org/D73961 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

2020-02-04 Thread Ayke via Phabricator via lldb-commits
aykevl created this revision. aykevl added reviewers: granata.enrico, labath, dylanmckay, Andrzej. Herald added subscribers: llvm-commits, lldb-commits, hiraditya. Herald added projects: LLDB, LLVM. Addresses are usually two bytes in size on AVR, so make sure LLDB deals with that. --- I'm not s