[Lldb-commits] [PATCH] D73935: [lldb] Remove clang classes from lldb-forward.h

2020-02-04 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7c9ebdd3d6ae: [lldb] Remove clang classes from lldb-forward.h (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73935/new/ https://review

[Lldb-commits] [PATCH] D73935: [lldb] Remove clang classes from lldb-forward.h

2020-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This is right. I would even go so far as to say that no plugin forward-declarations should be in that file. Based on a quick glance, I think this is mostly true already.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D73935: [lldb] Remove clang classes from lldb-forward.h

2020-02-03 Thread Alex Langford via Phabricator via lldb-commits
xiaobai created this revision. xiaobai added a reviewer: LLDB. Herald added a project: LLDB. lldb-forward.h is convenient in many ways, but having clang-based class forward declarations in there makes it easy to proliferate uses of clang outside of plugins. Removing them makes you much more consci