[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-31 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8be30215feef: [lldb] Move clang-based files out of Symbol (authored by xiaobai). Changed prior to commit: https://reviews.llvm.org/D73661?vs=241584&id=241791#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-31 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-31 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. Making this a plugin makes sense. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me, and I believe everyone else also felt the same way. There are still some loops here (TypeSystemClang<->SymbolFileDWARF/PDB), but I think those could be broken fairly eas

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Awesome, thanks for doing this Alex! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-30 Thread Alex Langford via Phabricator via lldb-commits
xiaobai added a comment. In D73661#1848750 , @labath wrote: > I think this is a big milestone. Thanks for working on this. > > The main question I have is about the new location of this code. This patch > puts it under ExpressionParser/Clang, which is no

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-30 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I vote to make this a plug-in as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-30 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Also this doesn't compile on Linux: FAILED: tools/lldb/source/Plugins/ABI/SysV-ppc64/CMakeFiles/lldbPluginABISysV_ppc64.dir/ABISysV_ppc64.cpp.o

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-30 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Pretty much what Pavel said, otherwise this LGTM. Maybe also rename/move the unit test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661 __

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

2020-01-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I think this is a big milestone. Thanks for working on this. The main question I have is about the new location of this code. This patch puts it under ExpressionParser/Clang, which is not completely unreasonable, as that's where most of the clang stuff is. However, it d